Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Update docstrings for paas_app_charmer's base charm.py #8

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Update docstrings for paas_app_charmer's base charm.py #8

merged 1 commit into from
Apr 11, 2024

Conversation

mthaddon
Copy link
Contributor

Applicable spec: N/A

Overview

Trivial change updating docstrings for paas_app_charmer's base charm.py.

Rationale

Improve docstrings.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@mthaddon mthaddon requested a review from a team as a code owner April 10, 2024 12:40
@github-actions GitHub Actions
Copy link

Test coverage for 292b94f

Name                                           Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------------------------
paas_app_charmer/__init__.py                       1      0      0      0   100%
paas_app_charmer/_gunicorn/__init__.py             0      0      0      0   100%
paas_app_charmer/_gunicorn/charm.py              116     29     18      6    72%   60-62, 147-148, 150-151, 171->exit, 181-185, 190, 196-201, 205-206, 210, 214, 218, 222, 226, 230, 234, 238, 242, 246
paas_app_charmer/_gunicorn/charm_state.py         63      1      6      1    97%   194
paas_app_charmer/_gunicorn/observability.py       20      0      0      0   100%
paas_app_charmer/_gunicorn/secret_storage.py      14      1      0      0    93%   39
paas_app_charmer/_gunicorn/webserver.py           76      5     16      2    92%   19, 155, 167-173
paas_app_charmer/_gunicorn/wsgi_app.py            60      1     22      1    98%   80
paas_app_charmer/database_migration.py            34      0      2      0   100%
paas_app_charmer/databases.py                     38      3     13      2    90%   82, 97-98
paas_app_charmer/django/__init__.py                2      0      0      0   100%
paas_app_charmer/django/charm.py                  45     13     10      0    65%   72-77, 89, 97-114
paas_app_charmer/exceptions.py                     5      0      0      0   100%
paas_app_charmer/flask/__init__.py                 2      0      0      0   100%
paas_app_charmer/flask/charm.py                   37      0      6      0   100%
paas_app_charmer/helpers.py                        9      0      2      1    91%   18->20
paas_app_charmer/secret_storage.py                40      6     16      4    79%   50, 54->53, 55->57, 85, 103-108
------------------------------------------------------------------------------------------
TOTAL                                            562     59    111     17    87%

Static code analysis report

Run started:2024-04-10 14:10:02.151813

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1240
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@jdkandersson jdkandersson merged commit 561ac9a into main Apr 11, 2024
28 checks passed
@jdkandersson jdkandersson deleted the pac-docstrings branch April 11, 2024 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arturo-seijas arturo-seijas arturo-seijas approved these changes

@jdkandersson jdkandersson jdkandersson approved these changes

@javierdelapuente javierdelapuente javierdelapuente approved these changes

Assignees
No one assigned
Labels
trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mthaddon @javierdelapuente @jdkandersson @arturo-seijas